Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset selector to core Franklin configuration #34

Open
mfrisbey opened this issue Aug 15, 2023 · 6 comments
Open

Add asset selector to core Franklin configuration #34

mfrisbey opened this issue Aug 15, 2023 · 6 comments
Assignees
Milestone

Comments

@mfrisbey
Copy link
Collaborator

mfrisbey commented Aug 15, 2023

The asset selector should be part of Franklin's core setup, meaning there shouldn't be special configuration required on the customer's end. We need to figure out what this looks like.

An initial thought is that the setup should only consist of adding the plugin (with very simple configurations) to a customer repository.

@tmathern
Copy link

An initial thought is that the setup should only consist of adding the plugin (with very simple configurations) to a customer repository. <= this will be made possible once we have a static URL hosted somewhere we'll be able to point to.

@tmathern tmathern self-assigned this Aug 25, 2023
@sdmcraft
Copy link
Collaborator

sdmcraft commented Sep 6, 2023

I think for phase-1 , we can add documentation on this in the Franklin Site which list the steps to get this working. I have edit access on the Franklin site so can take a stab at it. @tmathern feel free to reassign this to me.

@tmathern
Copy link

tmathern commented Sep 6, 2023

Sounds good!

@tmathern tmathern assigned sdmcraft and unassigned tmathern Sep 6, 2023
@sdmcraft
Copy link
Collaborator

sdmcraft commented Sep 7, 2023

@mfrisbey
Copy link
Collaborator Author

mfrisbey commented Sep 7, 2023

Thinking out loud here, but what would your thoughts be on adding a new button to the sidekick:

asset-button

(that's obviously just a mockup)

We could potentially control whether the button appears with a flag setting in the sidekick config (or maybe as a project setting in the UI):

{
  ...
  showAssets: true,
  ...
}

This might be more work, but IMO it has the following advantages:

  • It feels more truly integrated into the sidekick.
  • Customers aren't hard-coding the URL or palette definition, so we could have more control over updating those in the future from a central location.
  • It's even simpler for customers to set up.

What are your thoughts @sdmcraft @tmathern @badvision?

@sdmcraft
Copy link
Collaborator

sdmcraft commented Sep 8, 2023

would your thoughts be on adding a new button to the sidekick:

My thoughts are aligned on making this natively available in sidekick. This was the original requirement in this ticket as well. This likely would require a sidekick enhancement that I logged here adobe/helix-sidekick-extension#517 .
I see the documentation approach as an interim option for phase-1 till we get the sidekick enhanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants