Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Asset Selector Button to Sidekick #517

Closed
sdmcraft opened this issue Sep 8, 2023 · 6 comments
Closed

Add Asset Selector Button to Sidekick #517

sdmcraft opened this issue Sep 8, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@sdmcraft
Copy link

sdmcraft commented Sep 8, 2023

Is your feature request related to a problem? Please describe.
Currently, the customer has to configure AEM Assets Sidekick plugin as repo level. Ideally, for AEM customers. this is an extra step to link 2 AEM solutions (Franklin and Assets). This process can be simplified by making AEM Assets selector natively available in the sidekick.

Describe the solution you'd like
The AEM Asset selector should be natively available in the sidekick. A sidekick configuration like "Show AEM Assets" can be used to control its visibility.

Describe alternatives you've considered
The alternative is to setup this up as custom sidekick extension as customer's Franklin repository level.

Additional context
Please see related discussion in this issue hlxsites/franklin-assets-selector#34

@sdmcraft
Copy link
Author

sdmcraft commented Sep 8, 2023

Copying @rofe .

@rofe
Copy link
Contributor

rofe commented Sep 9, 2023

Which 5 projects are already using this feature?

@sdmcraft
Copy link
Author

Which 5 projects are already using this feature?

I don't think we have those yet. Though I know a couple of instances where this has been asked for and implemented on a branch for evaluation:

@rofe
Copy link
Contributor

rofe commented Sep 15, 2023

Then let's continue to add the button on the project side until we have usage and understand it.

@rofe rofe closed this as completed Sep 15, 2023
@sdmcraft
Copy link
Author

sdmcraft commented Oct 13, 2024

Coming back to this issue after a while. The asst selector addon is currently being used by 7 customers.

@rofe , do you think we should consider adding the assets button to the sidekick by default?

@rofe
Copy link
Contributor

rofe commented Oct 14, 2024

@sdmcraft please do not post any customer names or data in public github issues. I edited your post to hide customer names.

Looking at last month's data, I can only find moderate usage from the one of the customers you mentioned above. I don't think this even justifies removing the EAT banner from the doc page, let alone adding it as a standard sidekick feature at this point.

Having the plugin configured in customer projects and customers putting it to use are different things. When I said usage above, I meant the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants