Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): checkable tag #165

Merged
merged 2 commits into from
Sep 2, 2023
Merged

feat(component): checkable tag #165

merged 2 commits into from
Sep 2, 2023

Conversation

Catreap
Copy link
Contributor

@Catreap Catreap commented Aug 31, 2023

No description provided.

@greenhat616 greenhat616 self-requested a review August 31, 2023 10:42
greenhat616
greenhat616 requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@greenhat616 greenhat616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

做的不错。
不过，为什么要塞到 ActionsContainer 中呢？
可以使用 defineExpose 或者 Provide/Inject 解决这个问题吗？

@greenhat616 greenhat616 merged commit 22be9d3 into hitokoto-osc:next Sep 2, 2023
2 checks passed
@greenhat616
Copy link
Member

做了些修改，改成了 v-model 传值。
ffd1140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenhat616 greenhat616 greenhat616 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Catreap @greenhat616