feat: storage calls without user session

[yknl]

This PR allows storage calls without having a signed in user session.

#802

For details refer to issue #123

Type of Change

• New feature
• Bug fix
• API reference/documentation update
• Other

Does this introduce a breaking change?

No

Are documentation updates required?

No

Testing information

Checklist

• Code is commented where needed
• Unit test coverage for new or modified code paths
• npm run test passes
• Changelog is updated
• Tag 1 of @yknl or @zone117x for review

[codecov]

Codecov Report

Merging #836 into feature/monorepo-refactor will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##           feature/monorepo-refactor     #836      +/-   ##
=============================================================
- Coverage                      77.11%   77.10%   -0.02%     
=============================================================
  Files                             72       72              
  Lines                           4318     4320       +2     
  Branches                         762      763       +1     
=============================================================
+ Hits                            3330     3331       +1     
- Misses                           952      953       +1     
  Partials                          36       36              

Impacted Files	Coverage Δ
src/storage.ts	82.74% <0.00%> (-0.24%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a321ae...bb03e90. Read the comment docs.

[markmhendrickson]

This change seems straightforward enough. @yknl do you want me to test this as an integration in my app specifically or are you confident it'll work there?

[yknl]

@markmhx Yes, we can wait until you've had a chance to test it with your app, just want to make sure it resolves the issue for you.

[hstove]

Would love to see a test here but 👍

[markmhendrickson]

It appears that the userSession object is always available in this function, even if there's no actual session with related userData available. As such this conditional doesn't catch the lack of user data before reaching the need to retrieve a coreNode value on line 1321:

[markmhendrickson]

This conditional doesn't seem to resolve the underlying problem with calling this function when no session user data is available.

[markmhendrickson]

This appears to be affecting the todos app as well hirosystems/todos#55

[agraebe]

closing this for now. please re-open if you think this requires attention. if you re-open, please also suggest who could help resolve and carry it to the finish line 🙏🏼