refactor: Fix build breaking refactor changes #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janniks
commented
Oct 11, 2024
janniks
commented
- fix remnants of fix!: Compressing private key should ensure string format #1736 refactor
- remove helper in one location, to avoid circular dependency (in legacy code path)
- moves an internal helper function to different package
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
janniks
force-pushed
the
refactor_Fix_build_breaking_refactor
branch
from
e188e15
to
cd4b096
Compare
rafaelcr
approved these changes
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.