Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add origin post-condition principals #1730

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: Add origin post-condition principals #1730

merged 1 commit into from
Sep 17, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jul 29, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.14.1-pr.55+038e05c2
e.g. npm install @stacks/[email protected]+038e05c2 --save-exact

@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs 🛑 Canceled (Inspect) Sep 17, 2024 3:16pm

@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from 619f9b5 to 8b92d77 Compare July 29, 2024 18:54
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/transactions/src/postcondition.ts 60.00% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks requested a review from rafaelcr July 31, 2024 17:47
rafaelcr
rafaelcr approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from ffa62f5 to e9d8473 Compare July 31, 2024 20:13
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from 8b92d77 to 21aa4a6 Compare July 31, 2024 20:13
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from 21aa4a6 to b606515 Compare September 17, 2024 14:15
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from 1dad9b2 to 9ac757b Compare September 17, 2024 14:35
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch 2 times, most recently from 038e05c to dd514c0 Compare September 17, 2024 14:46
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch 2 times, most recently from 9966317 to bf8edba Compare September 17, 2024 14:50
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from dd514c0 to 4b34a9c Compare September 17, 2024 14:50
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from bf8edba to e1107f3 Compare September 17, 2024 14:54
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from 4b34a9c to 3f9373a Compare September 17, 2024 14:54
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from e1107f3 to b1b9bd8 Compare September 17, 2024 14:57
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from 3f9373a to 002b4e1 Compare September 17, 2024 14:57
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from b1b9bd8 to fc2d7dc Compare September 17, 2024 14:59
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from 002b4e1 to 2aa9846 Compare September 17, 2024 14:59
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from fc2d7dc to c00b38e Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch 2 times, most recently from a06e04d to 2e2effc Compare September 17, 2024 15:00
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch 2 times, most recently from 1720324 to e4add35 Compare September 17, 2024 15:02
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch 2 times, most recently from 345ea82 to 8ae173d Compare September 17, 2024 15:04
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from e4add35 to 000901a Compare September 17, 2024 15:04
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from 8ae173d to db1d4f7 Compare September 17, 2024 15:05
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from 000901a to 15e9d34 Compare September 17, 2024 15:05
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from db1d4f7 to d502113 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from 15e9d34 to 1588477 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from d502113 to a1bba86 Compare September 17, 2024 15:06
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch 2 times, most recently from e394ae5 to e8750eb Compare September 17, 2024 15:07
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch 2 times, most recently from 71bcca7 to e7a1ddc Compare September 17, 2024 15:08
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from e8750eb to 7a986ba Compare September 17, 2024 15:08
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from e7a1ddc to 7ea31ae Compare September 17, 2024 15:11
@janniks janniks force-pushed the 07-23-feat_add_address_namespace branch from 7a986ba to 24d5531 Compare September 17, 2024 15:11
Base automatically changed from 07-23-feat_add_address_namespace to next September 17, 2024 15:12
@janniks janniks force-pushed the 07-29-feat_add_origin_post-condition_principals branch from 7ea31ae to a553930 Compare September 17, 2024 15:12
@janniks janniks merged commit ccc79b3 into next Sep 17, 2024
1 of 3 checks passed
@janniks janniks deleted the 07-29-feat_add_origin_post-condition_principals branch September 17, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @rafaelcr