-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Address
namespace
#1729
Merged
Merged
+252
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
zone117x
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice DX
ffa62f5
to
e9d8473
Compare
a850882
to
966b602
Compare
1dad9b2
to
9ac757b
Compare
966b602
to
91f0bd2
Compare
9ac757b
to
9966317
Compare
91f0bd2
to
865827b
Compare
9966317
to
bf8edba
Compare
865827b
to
94e72f5
Compare
e1107f3
to
b1b9bd8
Compare
27ae2eb
to
39c312a
Compare
b1b9bd8
to
fc2d7dc
Compare
39c312a
to
c72e3bd
Compare
fc2d7dc
to
c00b38e
Compare
4a995da
to
f586da8
Compare
e4add35
to
000901a
Compare
02c1fb8
to
52bf6f3
Compare
000901a
to
15e9d34
Compare
15e9d34
to
1588477
Compare
2613915
to
47223ec
Compare
e394ae5
to
e8750eb
Compare
f9b531c
to
fa2b7e1
Compare
e8750eb
to
7a986ba
Compare
7a986ba
to
24d5531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
Cl
I'm trying to add more "namespace" objects.privateKeyToAddress
translation helper (and test)Address
namespace file with:.parse
.stringify
.fromPrivateKey
.fromPublicKey
Example DX