-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include tenure-height
in block responses
#2134
Conversation
0751754
to
1fb128b
Compare
1fb128b
to
f60693d
Compare
Vercel deployment URL: https://stacks-blockchain-kiubhwzia-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## [8.2.0-beta.1](v8.1.2...v8.2.0-beta.1) (2024-10-23) ### Features * allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef)) * include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2)) * ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154)) ### Bug Fixes * event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa))
🎉 This PR is included in version 8.2.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [8.2.0](v8.1.2...v8.2.0) (2024-10-25) ### Features * allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef)) * include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2)) * ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154)) ### Bug Fixes * event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa))
🎉 This PR is included in version 8.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #2124
And progress towards unblocking #2130
Ingest the
tenure_height
value added to/new_block
events in stacks-network/stacks-core#5333 (just added in core, requires a new RC).If the
tenure_height
is available, it's always returned in block endpoint responses. If it's missing and the block is epoch2.x then theblock_height
is returned as thetenure_height
(which is always accurate to assume).If it's missing in an epoch3 block, then
-1
is returned to indicate an error. The API will also print warnings logs when ingesting an epoch3 block event that is missingtenure_change
to indicate that the stacks-core version needs to be updated. This was done to prevent breaking current Nakamoto deployments that don't yet have an update stacks-core.