Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include tenure-height in block responses #2134

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Oct 21, 2024

Closes #2124

And progress towards unblocking #2130

Ingest the tenure_height value added to /new_block events in stacks-network/stacks-core#5333 (just added in core, requires a new RC).

If the tenure_height is available, it's always returned in block endpoint responses. If it's missing and the block is epoch2.x then the block_height is returned as the tenure_height (which is always accurate to assume).

If it's missing in an epoch3 block, then -1 is returned to indicate an error. The API will also print warnings logs when ingesting an epoch3 block event that is missing tenure_change to indicate that the stacks-core version needs to be updated. This was done to prevent breaking current Nakamoto deployments that don't yet have an update stacks-core.

Base automatically changed from fix/event-replay-bugs to develop October 21, 2024 14:20
Copy link

github-actions bot commented Oct 21, 2024

Vercel deployment URL: https://stacks-blockchain-kiubhwzia-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@zone117x zone117x marked this pull request as ready for review October 21, 2024 16:35
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zone117x zone117x merged commit 07426a2 into develop Oct 22, 2024
27 checks passed
@zone117x zone117x deleted the feat/tenure-height branch October 22, 2024 09:34
blockstack-devops pushed a commit that referenced this pull request Oct 23, 2024
## [8.2.0-beta.1](v8.1.2...v8.2.0-beta.1) (2024-10-23)

### Features

* allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef))
* include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2))
* ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154))

### Bug Fixes

* event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.2.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Oct 25, 2024
## [8.2.0](v8.1.2...v8.2.0) (2024-10-25)

### Features

* allow stackerdb_chunks messages to be stored in db raw events table ([d03f2ef](d03f2ef))
* include `tenure-height` in block responses ([#2134](#2134)) ([07426a2](07426a2))
* ingest `signer_signature` from `/new_block` event and expose in new endpoint ([#2125](#2125)) ([c389154](c389154))

### Bug Fixes

* event-replay block parsing outdated and incorrect ([#2133](#2133)) ([2cd69fa](2cd69fa))
@blockstack-devops
Copy link

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include block tenure_height
3 participants