Rename to fireAndCommit for now

hirethunk · Dec 7, 2023 · 1aebb83 · 1aebb83
1 parent a064533
commit 1aebb83
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/Event.php b/src/Event.php
@@ -11,7 +11,7 @@
 
 /**
  * @method static static fire(...$args)
- * @method static mixed fireNow(...$args)
+ * @method static mixed fireAndCommit(...$args)
  */
 abstract class Event
 {

diff --git a/src/Support/PendingEvent.php b/src/Support/PendingEvent.php
@@ -107,7 +107,8 @@ public function fire(...$args): Event
         }
     }
 
-    public function fireNow(...$args): mixed
+	// FIXME: This name *may* change, so be prepared to refactor
+    public function fireAndCommit(...$args): mixed
     {
         $event = $this->fire(...$args);
 

diff --git a/tests/Unit/EventApiTest.php b/tests/Unit/EventApiTest.php
@@ -24,8 +24,8 @@
         ->and($event_queue[0])->toBe($user_registered);
 });
 
-it('immediately commits, and returns the results of handle when you call Event::fireNow', function () {
-    $result = UserRegistered::fireNow();
+it('immediately commits, and returns the results of handle when you call Event::fireAndCommit', function () {
+    $result = UserRegistered::fireAndCommit();
 
     expect($result)->toBeInstanceOf(stdClass::class)
         ->and($result->name)->toBe('Chris')