-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error when importing actionwords #2
Conversation
would you add the package.json file to the repo please ? |
I’m not sure if we should add the package.json cause as far as I understand, this is the generated code by hiptest publisher. |
ii asked you to out package.json on repo to be able to make npm install without installing package manually. I modified the files locally ( actionwords and stepdefintions ans confirm that the fix is working for me. when yhe fix will be merged and i export actionword with publisher, ot will be ok or i should modify files manually every time ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to include const { I } = inject(); in actionwords when generating the fil with publisher ? actually we had to add it manually to actionwords.js to work with i object of codeceptjs
I think it was there in the template file. https://github.com/PeterNgTr/hps-javascript-codeceptjs/blob/f9c24553e0625a13c75526f34704f831c93a2046/templates/javascript/codeceptjs/actionwords.hbs#L1 |
Also I think the fix should be in here. hiptest/hiptest-publisher#166 |
As far as I recall, I had love the creation of the Actionword object inside the
Definitely, we should not fix output but the templates themselves. I'll having a look at your fixes now :) |
@vincent-psarga thanks. So probably my fix won't go as you wish cause I move the creation out of |
why closed ? :( |
@mfathallah this should be fixed in |
actionwords
output
folder fromcodeceptjs
as well aspackage-lock.json