Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when importing actionwords #2

Closed
wants to merge 2 commits into from

Conversation

kobenguyent
Copy link

@mfathallah
Copy link

would you add the package.json file to the repo please ?

@kobenguyent
Copy link
Author

I’m not sure if we should add the package.json cause as far as I understand, this is the generated code by hiptest publisher.

@mfathallah
Copy link

ii asked you to out package.json on repo to be able to make npm install without installing package manually. I modified the files locally ( actionwords and stepdefintions ans confirm that the fix is working for me. when yhe fix will be merged and i export actionword with publisher, ot will be ok or i should modify files manually every time ?

Copy link

@mfathallah mfathallah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to include const { I } = inject(); in actionwords when generating the fil with publisher ? actually we had to add it manually to actionwords.js to work with i object of codeceptjs

@kobenguyent
Copy link
Author

@kobenguyent
Copy link
Author

Also I think the fix should be in here. hiptest/hiptest-publisher#166

@vincent-psarga
Copy link
Contributor

As far as I recall, I had love the creation of the Actionword object inside the Before hook to ensure no persistence of data between tests.

Also I think the fix should be in here. hiptest/hiptest-publisher#166

Definitely, we should not fix output but the templates themselves. I'll having a look at your fixes now :)

@kobenguyent
Copy link
Author

kobenguyent commented Nov 4, 2019

@vincent-psarga thanks. So probably my fix won't go as you wish cause I move the creation out of before of template.

@kobenguyent kobenguyent closed this Nov 7, 2019
@mfathallah
Copy link

why closed ? :(

@kobenguyent
Copy link
Author

@mfathallah this should be fixed in hiptest-publisher not in this repo. This repo is just a demo to show what it is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants