Merge pull request #340 from hikka-io/fix/rename-to-restricted

Rename 'banned' to 'restricted'
hikka-io · Aug 28, 2024 · 016776a · 016776a
2 parents fc780f5 + b3733e7
commit 016776a
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 8 deletions.
diff --git a/app/constants.py b/app/constants.py
@@ -320,7 +320,7 @@
 ROLE_USER = "user"
 ROLE_MODERATOR = "moderator"
 ROLE_ADMIN = "admin"
-ROLE_BANNED = "banned"
+ROLE_RESTRICTED = "restricted"
 ROLE_NOT_ACTIVATED = "not_activated"
 ROLE_DELETED = "deleted"
 
@@ -394,7 +394,7 @@
         PERMISSION_UPLOAD_AVATAR,
         PERMISSION_UPLOAD_COVER,
     ],
-    ROLE_BANNED: [],
+    ROLE_RESTRICTED: [],
     ROLE_DELETED: [],
 }
 

diff --git a/tests/comments/test_comments_write.py b/tests/comments/test_comments_write.py
@@ -115,3 +115,18 @@ async def test_comments_write_empty_markdown(
 
     assert response.status_code == status.HTTP_400_BAD_REQUEST
     assert response.json()["code"] == "system:validation_error"
+
+
+async def test_comments_write_bad_permission(
+    client,
+    aggregator_anime,
+    aggregator_anime_info,
+    create_dummy_user_restricted,
+    get_dummy_token,
+):
+    response = await request_comments_write(
+        client, get_dummy_token, "edit", "17", "First comment, yay!"
+    )
+
+    assert response.status_code == status.HTTP_403_FORBIDDEN
+    assert response.json()["code"] == "permission:denied"
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -139,12 +139,12 @@ async def create_dummy_user(test_session):
 
 
 @pytest.fixture
-async def create_dummy_user_banned(test_session):
+async def create_dummy_user_restricted(test_session):
     return await helpers.create_user(
         test_session,
         username="dummy",
         email="[email protected]",
-        role=constants.ROLE_BANNED,
+        role=constants.ROLE_RESTRICTED,
     )
 
 

diff --git a/tests/edit/test_edit_close.py b/tests/edit/test_edit_close.py
@@ -99,7 +99,7 @@ async def test_edit_close_bad_permission(
     aggregator_anime,
     aggregator_anime_info,
     create_test_user,
-    create_dummy_user_banned,
+    create_dummy_user_restricted,
     get_test_token,
     get_dummy_token,
     test_session,

diff --git a/tests/edit/test_edit_create.py b/tests/edit/test_edit_create.py
@@ -149,7 +149,7 @@ async def test_edit_create_bad_permission(
     client,
     aggregator_anime,
     aggregator_anime_info,
-    create_dummy_user_banned,
+    create_dummy_user_restricted,
     get_dummy_token,
     test_session,
 ):

diff --git a/tests/upload/test_upload_avatar.py b/tests/upload/test_upload_avatar.py
@@ -31,7 +31,7 @@ async def test_upload_avatar(
 
 async def test_upload_avatar_bad_permission(
     client,
-    create_dummy_user_banned,
+    create_dummy_user_restricted,
     get_dummy_token,
     mock_s3_upload_file,
 ):

diff --git a/tests/upload/test_upload_cover.py b/tests/upload/test_upload_cover.py
@@ -34,7 +34,7 @@ async def test_upload_cover(
 
 async def test_upload_cover_bad_permission(
     client,
-    create_dummy_user_banned,
+    create_dummy_user_restricted,
     get_dummy_token,
     mock_s3_upload_file,
 ):