Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for boolean type during edits #407

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

michaelbukachi
Copy link
Collaborator

What issue(s) does this PR resolve?

Resolves #405
Resolves #337

Considerations and implementation

How to test

  1. Log in as ...
  2. Click on ...

Test(s) added

Mentions?

@amosnjoroge @andrewtpham @ninetteadhikari

@michaelbukachi michaelbukachi merged commit eda76de into develop Jan 16, 2023
@michaelbukachi michaelbukachi deleted the h-table_improvements branch January 16, 2023 07:10
@andrewtpham
Copy link
Member

It looks like the package version wasn't upgraded here. We will need to merge another PR that has a new package upgrade so these changes can be applied to Dots.

@michaelbukachi
Copy link
Collaborator Author

@andrewtpham Already did that:
#408

@andrewtpham
Copy link
Member

Oh right! thanks for pointing that out. I'll use that version to test in Dots now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for boolean on editable h-table Adding Controls - v1.0 refactor
3 participants