Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow connecting to a separate K8s server when running in a K8s cluster #385

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Dec 18, 2024

Ⅰ. Describe what this PR did

Allow connecting to a separate K8s server when running in a K8s cluster, so we can run all-in-one image in a K8s cluster.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from slievrly as a code owner December 18, 2024 06:44
@CH3CHO CH3CHO requested a review from johnlanni December 18, 2024 06:44
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 3d8a553 into higress-group:main Dec 18, 2024
4 checks passed
@CH3CHO CH3CHO deleted the feat/force-kubeconfig branch December 18, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants