Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update AI console function. #360

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Oct 18, 2024

Ⅰ. Describe what this PR did

  1. Update the data models of Consumer, LlmProvider and AiRoute.
  2. Return the original tokens instead of masked ones in ConsumersController and LlmProviderController.
  3. Fix auth functions in AI route.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

1. Update the data models of Consumer, LlmProvider and AiRoute.
2. Return the original tokens instead of masked ones in ConsumersController and LlmProviderController.
3. Fix auth functions in AI route.
@CH3CHO CH3CHO requested a review from johnlanni October 18, 2024 11:04
@CH3CHO CH3CHO requested a review from slievrly as a code owner October 18, 2024 11:04
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 76c6abd into higress-group:main Oct 21, 2024
4 checks passed
@CH3CHO CH3CHO deleted the feat/ai-console-api branch October 21, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants