Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only show ingress related notes when ingress is enabled #352

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Oct 12, 2024

Ⅰ. Describe what this PR did

Ingress not enabled (default)

image

Ingress enabled

image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested a review from johnlanni October 12, 2024 03:02
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 560b99c into higress-group:main Oct 15, 2024
4 checks passed
@CH3CHO CH3CHO deleted the fix/helm-ingress-notes branch October 16, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants