Jcorex-100:Most read and most cited #68
Conversation
| $alias = \Drupal::service('path_alias.manager')->getAliasByPath('/node/'.$nid); | ||
| $total_record[$alias] = $title; | ||
| } | ||
| $num_per_page = 3; |
There was a problem hiding this comment.
Let me know use of this variable? this is hardcoded by value 3.
There was a problem hiding this comment.
currently there is no configuration is created for details page how many records we have to show on one page so hardcoded for now. In future we can create configuration page.
| {{row.journal_title}} {{row.date_epub}} {{row.volume}}({{row.issue}}): {{ row.fpage }}-{{ row.lpage }}; DOI: https://doi.org/{{ row.doi}} | ||
| </p> | ||
| {% endfor %} | ||
| </ul> |
| </ul> | ||
| <div class="text-center altmetrics-pager">{{ pager }}</a> </div> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
Remove extra lines end of this file
| <li><a href="{{key}}">{{ title }}</a></br><hr></li> | ||
| {% endfor %} | ||
| </ul> | ||
| <a href="/content/{{corpus}}/most-read" class="nav-toggle">Read More</a> |
There was a problem hiding this comment.
Check alignment for a tag
| ]; | ||
| } | ||
| } | ||
|
|
| padding-left:0px; | ||
| } | ||
| #mostcited ul li { | ||
| padding-left:0px; |
There was a problem hiding this comment.
Space issue
padding-left: 0px;
| list-style-type: none; | ||
| } | ||
| #mostread .journals-articles-top ul>li:before, .page-node-type-page .block-region-right ul>li:before, .tab-content ul>li:before, ul.unorder-listing>li:before { | ||
| content: " " !important; |
There was a problem hiding this comment.
Check important here in all place of css
There was a problem hiding this comment.
whenever possible I have removed the important from css this place require important
#mostread .journals-articles-top ul>li:before, .page-node-type-page .block-region-right ul>li:before, .tab-content ul>li:before, ul.unorder-listing>li:before {
content: " " !important;
width: 0px !important;
}
| $alias = \Drupal::service('path_alias.manager')->getAliasByPath('/node/'.$nid); | ||
| $most_cited[$alias] = $title; | ||
| } | ||
| $build = []; |
There was a problem hiding this comment.
Any use of this variable?
| $node = $rows['#node']; | ||
| $title = $node->get('title')->value; | ||
| $nid = $node->get('nid')->value; | ||
| $alias = \Drupal::service('path_alias.manager')->getAliasByPath('/node/'.$nid); |
There was a problem hiding this comment.
space issue in the end '/node/'. $nid
| $mostCited = $block_manager->createInstance('most_read_cited_block', [ | ||
| 'read_cited' => $tab, | ||
| 'view_mode' => 'default', | ||
| 'limit' => 3, |
There was a problem hiding this comment.
Again hardcoded limit value
| @@ -83,8 +83,7 @@ function getData ($corpus,$tab) { | |||
| foreach ($authors as $key => $value) { | |||
| $author_names[$key] = $value['value']; | |||
| } | |||
| $authors_name = $author_names; | |||
| $authors=implode(' ',$authors_name); | |||
| $authors = implode(' ',$author_names); | |||
| $alias = \Drupal::service('path_alias.manager')->getAliasByPath('/node/'.$nid); | |||
There was a problem hiding this comment.
Space issue . getAliasByPath('/node/'. $nid);
| @@ -83,8 +83,7 @@ function getData ($corpus,$tab) { | |||
| foreach ($authors as $key => $value) { | |||
| $author_names[$key] = $value['value']; | |||
| } | |||
| $authors_name = $author_names; | |||
| $authors=implode(' ',$authors_name); | |||
| $authors = implode(' ',$author_names); | |||
There was a problem hiding this comment.
space issue $authors = implode(' ', $author_names);
| @@ -3,9 +3,11 @@ | |||
| <div id="mostread"> | |||
| <ul> | |||
| {% for key, title in most_read %} | |||
| <li><a href="{{key}}">{{ title }}</a></br><hr></li> | |||
| <li> | |||
| <a href="{{key}}">{{ title }} </a> | |||
There was a problem hiding this comment.
Extra space after title : {{ title }}
| @@ -28,8 +29,7 @@ | |||
| {% endif %} | |||
| <hr> | |||
| {% endfor %} | |||
| </ul> | |||
| </ul> | |||
|
|
|||
| <div class="text-center altmetrics-pager">{{ pager }}</a> </div> | |||
There was a problem hiding this comment.
Seems wrong tag added by you .
There was a problem hiding this comment.
this is variable is used for pagination
Jcorex-100:Most read and most cited