Skip to content

fixed svg rendering issue #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-turtles-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"rrweb-snapshot": patch
---

Handle exceptions thrown from postcss when calling adaptCssForReplay
47 changes: 47 additions & 0 deletions .github/workflows/eslint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Eslint Check

on: [pull_request]

jobs:
eslint_check_upload:
runs-on: ubuntu-latest
name: ESLint Check and Report Upload

steps:
- uses: actions/checkout@v3
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 16.15.0
registry-url: https://registry.npmjs.org
- name: Install
run: YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn
- name: Build Packages
run: yarn build:all
- name: Test Code Linting
run: yarn turbo run lint
- name: Save Code Linting Report JSON
run: yarn lint:report
# Continue to the next step even if this fails
continue-on-error: true
- name: Upload ESLint report
uses: actions/upload-artifact@v3
with:
name: eslint_report.json
path: eslint_report.json

Annotation:
# Skip the annotation action in PRs from the forked repositories
if: github.event.pull_request.head.repo.full_name == 'rrweb-io/rrweb'
needs: eslint_check_upload
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
with:
name: eslint_report.json
- name: Annotate Code Linting Results
uses: ataylorme/eslint-annotate-action@v2
with:
repo-token: '${{ secrets.GITHUB_TOKEN }}'
report-json: 'eslint_report.json'
18 changes: 17 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,22 @@ node_modules
package-lock.json
tsconfig.tsbuildinfo

# since this repo is referenced from the highlight monorepo which has its own yarn.lock file,
# don't include yarn.lock files from rrweb to avoid interfering with the monorepo
yarn.lock

.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions

packages/rrweb-player/lib
packages/rrweb-player/public
packages/rrweb-player/.svelte-kit/ambient.d.ts

temp

*.log
Expand All @@ -27,7 +43,7 @@ dist
# emacs working files end in a tilde
*~

# `.yarn/install-state.gz` is an optimization file that you shouldn't ever have to commit.
# `.yarn/install-state.gz` is an optimization file that you shouldn't ever have to commit.
# It simply stores the exact state of your project so that the next commands can boot without having to resolve your workspaces all over again.
.yarn/install-state.gz

Expand Down
Loading
Loading