Port HappyPandas to java #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public DataFrame squishPandaFromPace(DataFrame pandaPlace) { | ||
| Buffer<Column> inputCols = JavaConversions.asScalaBuffer(Arrays.asList(pandaPlace.col("pandas"))); | ||
|
|
||
| TypeTags.TypeTag tag = null; // TODO don't know how to create Type Tag in java ?? |
There was a problem hiding this comment.
@holdenk need help here
|
I think |
mahmoudhanafy
force-pushed
the
port-HappyPandas-to-Java
branch
4 times, most recently
from
da8e64d to
906524b
Compare
mahmoudhanafy
force-pushed
the
port-HappyPandas-to-Java
branch
2 times, most recently
from
578fc3a to
df0139d
Compare
Current coverage is 40.46%@@ master #49 diff @@
==========================================
Files 23 23
Lines 430 430
Methods 350 350
Messages 0 0
Branches 12 12
==========================================
- Hits 175 174 -1
- Misses 255 256 +1
Partials 0 0
|
mahmoudhanafy
force-pushed
the
port-HappyPandas-to-Java
branch
from
df0139d to
e792bb3
Compare
mahmoudhanafy
force-pushed
the
port-HappyPandas-to-Java
branch
from
b96afd5 to
b887283
Compare
mahmoudhanafy
force-pushed
the
port-HappyPandas-to-Java
branch
from
072c496 to
d7de259
Compare
|
This looks great! We should add an issue to track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47