Support license-maven-plugin-git #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyw4687
commented
Oct 4, 2022
| @@ -44,6 +44,7 @@ class LicenseIntegrationTest extends IntegrationSpec { | |||
|
|
|||
| license { | |||
| ignoreFailures = true | |||
| inceptionYear = 2011 | |||
There was a problem hiding this comment.
inceptionYear is needed while using license-maven-plugin-git
uyw4687
commented
Oct 4, 2022
| @@ -248,7 +249,7 @@ key2 = value2 | |||
| ExecutionResult r = runTasksSuccessfully("licenseFormatMain") | |||
|
|
|||
| then: | |||
| javaFile.text == '''/** | |||
| javaFile.text == '''/* | |||
uyw4687
commented
Oct 4, 2022
Comment on lines
+125
to
+133
| provider.init(new com.mycila.maven.plugin.license.AbstractLicenseMojo() { | ||
| { | ||
| defaultBasedir = baseDir; | ||
| } | ||
|
|
||
| for (String key : props.keySet()) { | ||
| properties.put(key, String.valueOf(props.get(key))); | ||
| @Override | ||
| public void execute() throws MojoExecutionException, MojoFailureException { | ||
| } | ||
| }, props); |
There was a problem hiding this comment.
AbstractLicenseMojos of maven and gradle plugins are different
|
@hierynomus Though this is a small change, we want to fork and publish in another repository. Please tell us if you have any concerns! |
|
Is there anyone who can review this PR and release a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #140
most of the codes are from license-maven-plugin
fixed some styles