Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix examples and run them in every new PR/per push #2830

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: fix examples and run them in every new PR/per push #2830

wants to merge 18 commits into from

Conversation

ivaylonikolov7
Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 commented Jan 28, 2025 •
edited
Loading

Description:

  • Runs all examples on each PR to ensure that examples run properly with each update
  • disable DAB example as it works only with Solo
  • fixes broken examples

Related issue(s):
#2802

Checklist:

  • Documented
  • Tested

@ivaylonikolov7
fix: broken examples
72c2319 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
exclude broken examples
dce7796 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: run examples on push/new pr
8a1e9ca 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: run examples
093ef6c 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: job fix formatting
5874654 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: fix formatting
db627ec 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: fix formatting
29755d8 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: fix formatting
2003ea4 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: add node
9645262 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: reorder pnpm and node
59f0252 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: install deps in examples
77ed960 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: fixes
8f29ae3 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7
ci: build sdk
c7b4849 
Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7 ivaylonikolov7 marked this pull request as ready for review January 28, 2025 15:34
@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners January 28, 2025 15:34
0xivanov
0xivanov reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@ivaylonikolov7
style: formatting
ac61f1e 
Signed-off-by: Ivaylo Nikolov <[email protected]>
ivaylogarnev-limechain
ivaylogarnev-limechain previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just resolve conflicts.

@ivaylonikolov7
style: fix formatting
b6e35a7 
Signed-off-by: Ivaylo Nikolov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xivanov 0xivanov 0xivanov left review comments

@PavelSBorisov PavelSBorisov PavelSBorisov approved these changes

@ivaylogarnev-limechain ivaylogarnev-limechain ivaylogarnev-limechain left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivaylonikolov7 @PavelSBorisov @0xivanov @ivaylogarnev-limechain