Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create-contract-with-value example #2825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: create-contract-with-value example #2825

wants to merge 1 commit into from

Conversation

ivaylonikolov7
Copy link
Contributor

Description:
This PR fixes create-contract-with-value example by executing the correct transaction. It was executing ContractCreateTransaction 2nd time therefore throwing DUPLICATE_TRANSACTION

Related issue(s):
#2801

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylonikolov7 ivaylonikolov7 requested a review from a team as a code owner January 27, 2025 12:43
0xivanov
0xivanov approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ivaylogarnev-limechain
ivaylogarnev-limechain approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivaylogarnev-limechain ivaylogarnev-limechain ivaylogarnev-limechain approved these changes

@venilinvasilev venilinvasilev venilinvasilev approved these changes

@0xivanov 0xivanov 0xivanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivaylonikolov7 @0xivanov @venilinvasilev @ivaylogarnev-limechain