Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bumped Typescript version #2797

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

ivaylogarnev-limechain
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain commented Jan 17, 2025

Description:
This PR updates the TypeScript versions to the latest stable releases across various TypeScript directories within the project and resolves any resulting type-related errors.

Related issue(s):
#2665

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylogarnev-limechain ivaylogarnev-limechain marked this pull request as ready for review January 17, 2025 11:38
@ivaylogarnev-limechain ivaylogarnev-limechain requested a review from a team as a code owner January 17, 2025 11:38
@ivaylonikolov7
Copy link
Contributor

Not a huge fan of these patch fixes with the ts-ignore. Can't we do it any other way?

@ivaylogarnev-limechain
Copy link
Contributor Author

Not a huge fan of these patch fixes with the ts-ignore. Can't we do it any other way?

I tried using JSDOC for type assertions, but it didn't work as expected. Since these files are written in JavaScript and not TypeScript, using TypeScript type assertions isn't an option also. Ultimately, whether we use ts-ignore or specify the type with JSDOC explicitly, neither approach are correct.

Another potential solution would be to refactor the code to meet the new type constraints. However, given that this is legacy code within the cryptography package, a refactor doesn’t seem like a practical solution at this stage. Furthermore, I’ve noticed that ts-ignore is already used in various parts within the project so I think its not a big deal.

@ivaylonikolov7
Copy link
Contributor

ivaylonikolov7 commented Jan 20, 2025

Okay, can you just update the package.json and its LGTM.

package.json Outdated Show resolved Hide resolved
@ivaylogarnev-limechain ivaylogarnev-limechain merged commit 4d085ea into main Jan 21, 2025
9 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the chore/upgrade-typescript-version branch January 21, 2025 10:06
This was referenced Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants