Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enhance gRPC TLS by Dynamic Certificate Retrieval #2718

Merged
merged 10 commits into from
Dec 17, 2024

Conversation

ivaylogarnev-limechain
Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain commented Dec 13, 2024

Description:
This PR fixes an issue where the Hedera SDK fails to establish secure connections with nodes whose certificates are not included in the NODE_CERT.js file. It enhances the SDK to dynamically retrieve and validate certificates during the TLS handshake, ensuring secure communication with all nodes on mainnet, testnet, and previewnet.

Related issue(s):
#2717

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylogarnev-limechain ivaylogarnev-limechain changed the title bug: Added dynamically retrieving for the gRPC certifications chore: Added dynamically retrieving for the gRPC certifications Dec 13, 2024
@ivaylogarnev-limechain ivaylogarnev-limechain changed the title chore: Added dynamically retrieving for the gRPC certifications chore: Enhance gRPC TLS by Dynamic Certificate Retrieval Dec 13, 2024
@ivaylogarnev-limechain ivaylogarnev-limechain marked this pull request as ready for review December 13, 2024 13:38
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, just some clarification questions.

src/constants/ClientConstants.js Show resolved Hide resolved
src/channel/NodeChannel.js Show resolved Hide resolved
src/channel/NodeChannel.js Outdated Show resolved Hide resolved
src/channel/NodeChannel.js Show resolved Hide resolved
src/channel/NodeChannel.js Show resolved Hide resolved
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylogarnev-limechain ivaylogarnev-limechain merged commit c66beb8 into main Dec 17, 2024
10 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the bug/grpc-tls-communication branch December 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants