-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Integration Test for NodeCreateTransaction and FQDN support #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gsstoykov <[email protected]>
…atus.h Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
…s-for-address-book-entries' into 00782-test-nodecreatetransaction-with-solo Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
gsstoykov
changed the title
feat: Added Integration Test for NodeCreateTransaction
feat: Added Integration Test for NodeCreateTransaction and FQDN support
Oct 15, 2024
Actual commands used to start solo and expose Solo to SDK integration tests.
|
rwalworth
reviewed
Oct 15, 2024
jeromy-cannon
previously approved these changes
Oct 15, 2024
Signed-off-by: gsstoykov <[email protected]>
rwalworth
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR serves as a POC for using NodeCreateTransaction. Adds the capability to create Networks via Endpoints containing domain names instead of IPv4 addresses.
Related issue(s):
Fixes #782 #732
Notes for reviewer:
Can be merged even if POC as it adds an Integration test. CI will fail against
local-node
so the test will be disabled(It needsSolo
configured in our CI).Checklist