Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Integration Test for NodeCreateTransaction and FQDN support #787

Merged
merged 11 commits into from
Oct 16, 2024

Conversation

gsstoykov
Copy link
Contributor

@gsstoykov gsstoykov commented Oct 9, 2024

Description:
This PR serves as a POC for using NodeCreateTransaction. Adds the capability to create Networks via Endpoints containing domain names instead of IPv4 addresses.

Related issue(s):

Fixes #782 #732

Notes for reviewer:
Can be merged even if POC as it adds an Integration test. CI will fail against local-node so the test will be disabled(It needs Solo configured in our CI).

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@gsstoykov gsstoykov added the Improvement Code changes driven by non business requirements label Oct 9, 2024
@gsstoykov gsstoykov self-assigned this Oct 9, 2024
@gsstoykov gsstoykov linked an issue Oct 9, 2024 that may be closed by this pull request
@gsstoykov gsstoykov linked an issue Oct 15, 2024 that may be closed by this pull request
@gsstoykov gsstoykov marked this pull request as ready for review October 15, 2024 12:09
@gsstoykov gsstoykov requested review from a team as code owners October 15, 2024 12:09
@gsstoykov gsstoykov changed the title feat: Added Integration Test for NodeCreateTransaction feat: Added Integration Test for NodeCreateTransaction and FQDN support Oct 15, 2024
@gsstoykov
Copy link
Contributor Author

Actual commands used to start solo and expose Solo to SDK integration tests.

// clears cached certificates and etc.
rm -rf ~/.solo/cache
rm ~/.solo/solo.config

export SOLO_CLUSTER_NAME=solo-e2e
export SOLO_NAMESPACE=solo-e2e
export SOLO_CLUSTER_SETUP_NAMESPACE=fullstack-setup
kind delete cluster -n "${SOLO_CLUSTER_NAME}"
kind create cluster -n "${SOLO_CLUSTER_NAME}"

// Could create n nodes if listed like node1,node2... I strongly recommend 
// creating at most 1-2 nodes
npm run solo -- init --namespace "${SOLO_NAMESPACE}" -i node1 -s "${SOLO_CLUSTER_SETUP_NAMESPACE}"
npm run solo -- node keys --gossip-keys --tls-keys
npm run solo -- cluster setup
npm run solo -- network deploy --pvcs true
npm run solo -- node setup
npm run solo -- node start

// forwards the port which the SDKs integrationt tests are set to run against
kubectl port-forward svc/haproxy-node1-svc -n "${SOLO_NAMESPACE}" 50211:50211 &

// Optional mirror node deploy
npm run solo mirror-node deploy

// Optional hashscan - requires mirror node deploy
kubectl port-forward svc/fullstack-deployment-hedera-explorer -n "${SOLO_NAMESPACE}" 8080:80 &

jeromy-cannon
jeromy-cannon previously approved these changes Oct 15, 2024
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsstoykov gsstoykov merged commit 32e7eb8 into main Oct 16, 2024
6 checks passed
@gsstoykov gsstoykov deleted the 00782-test-nodecreatetransaction-with-solo branch October 16, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements
Projects
None yet
3 participants