Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: HIP-551 fee charging negative test cases #17945

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Feb 19, 2025

Covering the negative test cases for fee charging for HIP-551.

@ibankov ibankov added this to the v0.60 milestone Feb 19, 2025
@ibankov ibankov self-assigned this Feb 19, 2025
# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip551/AtomicBatchNegativeTest.java
@ibankov ibankov marked this pull request as ready for review February 19, 2025 15:02
@ibankov ibankov requested review from a team as code owners February 19, 2025 15:02
@povolev15 povolev15 linked an issue Feb 19, 2025 that may be closed by this pull request
Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY @ibankov LGTM

Copy link
Contributor

@vtronkov vtronkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small comment, LGTM

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip551/AtomicBatchNegativeTest.java
Signed-off-by: ibankov <[email protected]>
@ibankov ibankov merged commit e497663 into hip-551-batch-txs Feb 20, 2025
41 checks passed
@ibankov ibankov deleted the 17655-fees---negative branch February 20, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fees - NEGATIVE
3 participants