-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 17847 fixed English typos in License Terms, docs , user comments… #17848
base: main
Are you sure you want to change the base?
Conversation
… and scripts Signed-off-by: Alex Kuzmin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM but see:
- Don't change uses of
oneof
to "one of" - For some of the changes in
.json
files I pointed to - ensure someone who knows how these configurations are consumed checks them please
example-apps/swirlds-platform-base-example/docker/grafana/dashboards/dashboard.json
Show resolved
Hide resolved
...ice-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/utils/ActionStack.java
Outdated
Show resolved
Hide resolved
hedera-node/infrastructure/grafana/dashboards/production/hedera-node/entity-utilization.json
Outdated
Show resolved
Hide resolved
hedera-node/infrastructure/grafana/dashboards/production/hedera-node/network-details-prom.json
Show resolved
Hide resolved
hedera-node/infrastructure/grafana/dashboards/production/hedera-node/throttle-utlization.json
Outdated
Show resolved
Hide resolved
...tests/PlatformTestingTool/src/main/java/com/swirlds/demo/merkle/map/FCMTransactionUtils.java
Outdated
Show resolved
Hide resolved
...StatsSigningTestingTool/src/main/java/com/swirlds/demo/stats/signing/SttTransactionPool.java
Show resolved
Hide resolved
platform-sdk/swirlds-benchmarks/src/jmh/java/com/swirlds/benchmark/config/BenchmarkConfig.java
Show resolved
Hide resolved
...c/testFixtures/java/com/swirlds/platform/test/fixtures/state/RandomSignedStateGenerator.java
Show resolved
Hide resolved
Signed-off-by: Alex Kuzmin <[email protected]>
Signed-off-by: Alex Kuzmin <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Alex Kuzmin <[email protected]>
Signed-off-by: Alex Kuzmin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to check that devops doesn't depend on any of these logging statements (for alerts etc.)
...ormTestingTool/src/main/java/com/swirlds/demo/merkle/map/internal/ExpectedFCMFamilyImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Kuzmin <[email protected]>
261b68c
...ormTestingTool/src/main/java/com/swirlds/demo/merkle/map/internal/ExpectedFCMFamilyImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Kuzmin <[email protected]>
….com/hashgraph/hedera-services into 17847_English_typos_in_docs_comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and approve:
.github/workflows/support/scripts/loki-logs.sh
hedera-node/infrastructure/grafana/dashboards/production/hedera-node/network-details-prom.json
hedera-node/infrastructure/grafana/dashboards/production/hedera-node/throttle-utlization.json
hedera-node/infrastructure/grafana/dashboards/production/platform/networkHealth.json
hedera-node/infrastructure/grafana/dashboards/production/platform/threadsAndQueues.json
… and scripts
Description:
Fixed off-code English spelling typos, e.g. license text, comments etc
Related issue(s):
Fixes # 17847
Notes for reviewer:
Checklist