Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 17847 fixed English typos in License Terms, docs , user comments… #17848

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

alex-kuzmin-hg
Copy link
Contributor

… and scripts

Description:
Fixed off-code English spelling typos, e.g. license text, comments etc

Related issue(s):

Fixes # 17847

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • [X ] Tested (unit, integration, etc.)

david-bakin-sl
david-bakin-sl previously approved these changes Feb 12, 2025
Copy link
Contributor

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but see:

  • Don't change uses of oneof to "one of"
  • For some of the changes in .json files I pointed to - ensure someone who knows how these configurations are consumed checks them please

Copy link

codacy-production bot commented Feb 12, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (570df2e) 99458 72533 72.93%
Head commit (7896d65) 99458 (+0) 72536 (+3) 72.93% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17848) 2 1 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

mhess-swl
mhess-swl previously approved these changes Feb 20, 2025
Copy link
Contributor

@mhess-swl mhess-swl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to check that devops doesn't depend on any of these logging statements (for alerts etc.)

vtronkov
vtronkov previously approved these changes Feb 20, 2025
thenswan
thenswan previously approved these changes Feb 20, 2025
Signed-off-by: Alex Kuzmin <[email protected]>
@alex-kuzmin-hg alex-kuzmin-hg dismissed stale reviews from thenswan, vtronkov, and mhess-swl via 261b68c February 20, 2025 18:48
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and approve:

.github/workflows/support/scripts/loki-logs.sh
hedera-node/infrastructure/grafana/dashboards/production/hedera-node/network-details-prom.json
hedera-node/infrastructure/grafana/dashboards/production/hedera-node/throttle-utlization.json
hedera-node/infrastructure/grafana/dashboards/production/platform/networkHealth.json
hedera-node/infrastructure/grafana/dashboards/production/platform/threadsAndQueues.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants