Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 17695 fixed English typos in user messages #17844

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

alex-kuzmin-hg
Copy link
Contributor

@alex-kuzmin-hg alex-kuzmin-hg commented Feb 12, 2025

Description:
Fixed typos in user massages

Related issue(s):

Fixes #17695

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • [ X] Tested (unit, integration, etc.)

david-bakin-sl
david-bakin-sl previously approved these changes Feb 12, 2025
Copy link
Contributor

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and TY Alex! My strong OCD tendencies salute you!!!

(P.S. Now do misspelled field and variable names please!)

@alex-kuzmin-hg alex-kuzmin-hg self-assigned this Feb 12, 2025
@alex-kuzmin-hg alex-kuzmin-hg added this to the v0.60 milestone Feb 12, 2025
Signed-off-by: Alex Kuzmin <[email protected]>
Signed-off-by: Alex Kuzmin <[email protected]>
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.02%. Comparing base (570df2e) to head (5809235).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...main/java/com/hedera/node/app/fees/FeeManager.java 0.00% 1 Missing ⚠️
...java/com/swirlds/platform/gui/model/Reference.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17844   +/-   ##
=========================================
  Coverage     69.01%   69.02%           
- Complexity    23050    23055    +5     
=========================================
  Files          2655     2655           
  Lines         99675    99675           
  Branches      10289    10289           
=========================================
+ Hits          68795    68802    +7     
- Misses        26981    26982    +1     
+ Partials       3899     3891    -8     
Files with missing lines Coverage Δ
.../app/hapi/utils/exports/RecordBlockNumberTool.java 0.00% <ø> (ø)
...main/java/com/hedera/node/app/fees/FeeManager.java 72.72% <0.00%> (ø)
...java/com/swirlds/platform/gui/model/Reference.java 0.00% <0.00%> (ø)

... and 12 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (570df2e) 99458 72533 72.93%
Head commit (5809235) 99458 (+0) 72532 (-1) 72.93% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17844) 2 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@alex-kuzmin-hg
Copy link
Contributor Author

alex-kuzmin-hg commented Feb 12, 2025

passed all tests

@alex-kuzmin-hg alex-kuzmin-hg merged commit 2f9ee30 into main Feb 20, 2025
41 checks passed
@alex-kuzmin-hg alex-kuzmin-hg deleted the 17695_English_typos_in_user_messages branch February 20, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

English typos in user messages/string literals
5 participants