feat: shadowing

Signed-off-by: Mariusz Jasuwienas <[email protected]>
hiero-ledger · Oct 11, 2024 · aa694e8 · aa694e8
1 parent 872ca1a
commit aa694e8
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/hedera-node/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/ethereum/EthTxData.java b/hedera-node/hapi-utils/src/main/java/com/hedera/node/app/hapi/utils/ethereum/EthTxData.java
@@ -341,8 +341,15 @@ public boolean hasToAddress() {
 
     public boolean matchesChainId(final byte[] hederaChainId) {
         // first two checks handle the unprotected ethereum transactions
-        // before EIP155 - source: https://eips.ethereum.org/EIPS/eip-155
-        return chainId == null || chainId.length == 0 || Arrays.compare(chainId, hederaChainId) == 0;
+        // before EIP155 - source: [https://eips.ethereum.org/EIPS/eip-155](https://eips.ethereum.org/EIPS/eip-155)
+        if (chainId == null || chainId.length == 0) {
+            return true;
+        }
+
+        // Convert both chain IDs to BigInteger for comparison
+        BigInteger parsedHederaChainId = new BigInteger(1, hederaChainId);
+        BigInteger parsedChainId = new BigInteger(1, chainId);
+        return parsedHederaChainId.equals(parsedChainId);
     }
 
     @VisibleForTesting