Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

Fix downloadeds files #35

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Fix downloadeds files #35

merged 2 commits into from
Dec 13, 2018

Conversation

olaferlandsen
Copy link
Contributor

@olaferlandsen olaferlandsen commented Oct 29, 2018

Fix "Unknown URI" for Downloads
See more info about this bug in issue #34

@synnottd
Copy link

I'm no Java expert but is this missing an import for TextUtils?

@olaferlandsen
Copy link
Contributor Author

I'm no Java expert but is this missing an import for TextUtils?

import android.text.TextUtils;

@synnottd
Copy link

I'm no Java expert but is this missing an import for TextUtils?

import android.text.TextUtils;

Yes :), my point being it needs to be added to this PR.

@olaferlandsen
Copy link
Contributor Author

@Daithi1 fixed

@michal-th
Copy link

@hiddentao are you planning to merge this PR anytime soon please?

@hiddentao
Copy link
Owner

@michal-th @ChrizC Is this PR merge-able?

@olaferlandsen
Copy link
Contributor Author

@michal-th @ChrizC Is this PR merge-able?

Yes, this PR no have conflicts, and it works.
You can try it using

$ ionic cordova plugin rm cordova-plugin-filepath
$ ionic cordova plugin add https://github.com/olaferlandsen/cordova-plugin-filepath

@hiddentao hiddentao merged commit db6b1d9 into hiddentao:master Dec 13, 2018
@Abhi0725
Copy link

Is this merged?

@olaferlandsen
Copy link
Contributor Author

Is this merged?

yep...

@hiddentao
Copy link
Owner

Somehow I've lost my publishing rights to the NPM package so am attempting to regain them - as soon as I have them I will publish 1.5.0 with this fix!

@hiddentao
Copy link
Owner

This is now available in 1.5.0 :)

@michal-th
Copy link

great thank you @hiddentao and @olaferlandsen for this.

Btw the version in plugin.xml still says 1.4.2 (package.json correctly states 1.5.0) but i verified the fix is indeed applied in the code, will test it on devices in a while.

@hiddentao
Copy link
Owner

@michal-th Ah, thanks for spotting that. Have pushed 1.5.1 with plugin.xml also fixed.

@olaferlandsen
Copy link
Contributor Author

This is now available in 1.5.0 :)

please create realease in github.

@hiddentao
Copy link
Owner

@olaferlandsen Done -> https://github.com/hiddentao/cordova-plugin-filepath/releases/tag/1.5.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants