-
Notifications
You must be signed in to change notification settings - Fork 130
Conversation
I'm no Java expert but is this missing an import for TextUtils? |
|
Yes :), my point being it needs to be added to this PR. |
@Daithi1 fixed |
@hiddentao are you planning to merge this PR anytime soon please? |
@michal-th @ChrizC Is this PR merge-able? |
Yes, this PR no have conflicts, and it works. $ ionic cordova plugin rm cordova-plugin-filepath
$ ionic cordova plugin add https://github.com/olaferlandsen/cordova-plugin-filepath |
Is this merged? |
yep... |
Somehow I've lost my publishing rights to the NPM package so am attempting to regain them - as soon as I have them I will publish 1.5.0 with this fix! |
This is now available in 1.5.0 :) |
great thank you @hiddentao and @olaferlandsen for this. Btw the version in plugin.xml still says 1.4.2 (package.json correctly states 1.5.0) but i verified the fix is indeed applied in the code, will test it on devices in a while. |
@michal-th Ah, thanks for spotting that. Have pushed 1.5.1 with plugin.xml also fixed. |
please create realease in github. |
Fix "Unknown URI" for Downloads
See more info about this bug in issue #34