-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logic to use content_url
for thread/comment bodies if present
#9461
Added logic to use content_url
for thread/comment bodies if present
#9461
Conversation
content_url
for thread/comment bodies if present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be loading thread content URLs correctly but version history doesn't work.
If I edit a thread I need to refresh to see the update and once I do I can no longer switch back to earlier versions of the thread (the UI doesn't update). In other words I could not follow your test plan.
So there were a lot of complex component states involved (switch from 2k+ chars version to <2k chars and its different combinations), and it crashed with certain use cases. I trimmed it all down, and it should work correctly now. Please see the updated test plan to test out all the possible issues. |
followed test plan, everything worked fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Link to Issue
Closes: #8670
Description of Changes
content_url
for thread/comment bodies (if present)content_url
to fetch thread/comment bodies (if present)"How We Fixed It"
N/A
Test Plan
2
, and verify it works correctly.Deployment Plan
N/A
Other Considerations
N/A