-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design System: Tooltips #4123
Comments
Please note a requirement here is to use mui-base. |
The thing is: mui-base does not have the Tooltip component implemented yet: here Options:
If yes to second question, PR is here: #4514 |
That's a bummer. Some time ago I proposed that we could use https://www.radix-ui.com/ as they have a lot of components and generally the lib has great reviews. If we don't want to use anything else though, we should keep using mui-base. In this case, we have to stick to their |
I'm down for using only one ui library. We could use mui-base but it's on its early stages, so changing from library to library is not a good idea. I used mui on previous projects, they also have a lot of components already built. Popper would be a good one. |
@zakhap component is ready for review. Just a last question about its behaviour: Should the tooltip appear when element is clicked or just hovered? |
Description
Figma: https://www.figma.com/file/eIVp33a1oCu0AtcLwSbGjr/%F0%9F%9A%A7-Components-and-Patterns?type=design&node-id=481-4642&t=KXxdmSCtWpGv6n0A-0
Acceptance Criteria
The text was updated successfully, but these errors were encountered: