HHH-16861 HQL ordinal() function #8991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
lucamolteni
force-pushed
the
HHH-16861
branch
from
f283017
to
6ea6a64
Compare
gavinking
requested changes
Sep 22, 2024
hibernate-core/src/main/antlr/org/hibernate/grammars/hql/HqlLexer.g4
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/antlr/org/hibernate/grammars/hql/HqlParser.g4
Outdated
Show resolved
Hide resolved
lucamolteni
force-pushed
the
HHH-16861
branch
from
6ea6a64
to
bdf889d
Compare
I'm working on that part now |
Awesome, that's great, thanks man. |
lucamolteni
force-pushed
the
HHH-16861
branch
from
bdf889d
to
80bcd88
Compare
lucamolteni
commented
Sep 25, 2024
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
beikov
reviewed
Sep 25, 2024
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
lucamolteni
changed the title
beikov
reviewed
Sep 26, 2024
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
...nate-core/src/main/java/org/hibernate/query/sqm/produce/function/ArgumentTypesValidator.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/jdbc/JdbcType.java
Outdated
Show resolved
Hide resolved
lucamolteni
force-pushed
the
HHH-16861
branch
from
531ac99
to
9b71811
Compare
beikov
reviewed
Sep 26, 2024
hibernate-core/src/main/java/org/hibernate/dialect/function/OrdinalFunction.java
Outdated
Show resolved
Hide resolved
lucamolteni
force-pushed
the
HHH-16861
branch
from
9b71811
to
76e2c43
Compare
beikov
approved these changes
Sep 26, 2024
The `ordinal` function returns the `ordinal` property of Java enums, for both enums mapped as ORDINAL and enums mapped as STRING generating different SQL in each case `ordinal(field)` is equivalent to `cast(enum as Integer)`, implementation taken from CastStrEmulation when used on ordinal mapped enums. Lexer and parser don't need to be changed as there is nakedIdentifier that matches custom function names `ordinal` function is validated to work only on Java enum fields Use convertToRelationalValue to generate enum value inside the SQL query Co-authored-by: Christian Beikov <[email protected]>
lucamolteni
force-pushed
the
HHH-16861
branch
from
76e2c43
to
c674798
Compare
|
Thanks for the great work @lucamolteni. Would very much appreciate if you could add some documentation for this function as well e.g. in |
|
Thanks @lucamolteni !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the
hqlordinal(field)function equivalent tocast(enum as Integer).Implementation taken from CastStrEmulation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-16861