-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-18588 fix minor defects in Hibernate Introduction article #8912
Open
NathanQingyangXu
wants to merge
1
commit into
hibernate:main
Choose a base branch
from
NathanQingyangXu:HHH-18588-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanQingyangXu
commented
Sep 9, 2024
gavinking
reviewed
Sep 9, 2024
gavinking
reviewed
Sep 9, 2024
gavinking
reviewed
Sep 9, 2024
gavinking
reviewed
Sep 9, 2024
NathanQingyangXu
changed the title
HHH-18588 fix minor defects in Hibernate Introduction article (chapter 1: Introduction)
HHH-18588 fix minor defects in Hibernate Introduction article (ch1)
Sep 10, 2024
NathanQingyangXu
changed the title
HHH-18588 fix minor defects in Hibernate Introduction article (ch1)
HHH-18588 fix minor defects in Hibernate Introduction article (ch1 and ch2)
Sep 10, 2024
documentation/src/main/asciidoc/introduction/Configuration.adoc
Outdated
Show resolved
Hide resolved
NathanQingyangXu
changed the title
HHH-18588 fix minor defects in Hibernate Introduction article (ch1 and ch2)
HHH-18588 fix minor defects in Hibernate Introduction article
Sep 10, 2024
gavinking
requested changes
Sep 10, 2024
documentation/src/main/asciidoc/introduction/Configuration.adoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/introduction/Configuration.adoc
Outdated
Show resolved
Hide resolved
NathanQingyangXu
force-pushed
the
HHH-18588-new
branch
from
September 11, 2024 02:59
45f4a3e
to
abe3a85
Compare
@gavinking , I finished checking the whole doc. I learned a lot during the process. Thanks for the brillant and insightful documentation! |
NathanQingyangXu
force-pushed
the
HHH-18588-new
branch
from
September 11, 2024 14:58
abe3a85
to
c4a60fb
Compare
I also created a similar PR for Hibernate Query Language doc at #8941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-18588
Fixed some minor defects.