HHH-17068, HHH-18585 move layer-breaking enums #8897
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| default <X> JpaEntityJoin<T, X> join(Class<X> entityJavaType, SqmJoinType joinType) { | ||
| return join( entityJavaType, joinType.getCorrespondingJpaJoinType() ); | ||
| } | ||
|
|
||
| default <X> JpaEntityJoin<T, X> join(Class<X> entityJavaType, org.hibernate.query.common.JoinType joinType) { | ||
| return join( entityJavaType, SqmJoinType.from(joinType) ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| <X> JpaEntityJoin<T,X> join(EntityDomainType<X> entity, SqmJoinType joinType); | ||
|
|
||
| default <X> JpaEntityJoin<T,X> join(EntityDomainType<X> entity, org.hibernate.query.common.JoinType joinType) { | ||
| return join( entity, SqmJoinType.from(joinType) ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| <X> JpaDerivedJoin<X> join(Subquery<X> subquery, SqmJoinType joinType); | ||
|
|
||
| default <X> JpaDerivedJoin<X> join(Subquery<X> subquery, org.hibernate.query.common.JoinType joinType) { | ||
| return join( subquery, SqmJoinType.from(joinType) ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| <X> JpaDerivedJoin<X> joinLateral(Subquery<X> subquery, SqmJoinType joinType); | ||
|
|
||
| @Incubating | ||
| default <X> JpaDerivedJoin<X> joinLateral(Subquery<X> subquery, org.hibernate.query.common.JoinType joinType) { | ||
| return joinLateral( subquery, SqmJoinType.from(joinType) ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| <X> JpaDerivedJoin<X> join(Subquery<X> subquery, SqmJoinType joinType, boolean lateral); | ||
|
|
||
| default <X> JpaDerivedJoin<X> join(Subquery<X> subquery, org.hibernate.query.common.JoinType joinType, boolean lateral) { | ||
| return join( subquery, SqmJoinType.from(joinType), lateral ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| <X> JpaJoin<?, X> join(JpaCteCriteria<X> cte, SqmJoinType joinType); | ||
|
|
||
| default <X> JpaJoin<?, X> join(JpaCteCriteria<X> cte, org.hibernate.query.common.JoinType joinType) { | ||
| return join( cte, SqmJoinType.from(joinType) ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Signed-off-by: Gavin King <[email protected]>
…a API fis the layer-breakage Signed-off-by: Gavin King <[email protected]>
Signed-off-by: Gavin King <[email protected]>
Signed-off-by: Gavin King <[email protected]>
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
gavinking
changed the title
gavinking
changed the title
|
@sebersole got time to review this? Apologies for nagging. |
|
Could you run spotless on this? ;) Otherwise, looks good to me |
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-17068
https://hibernate.atlassian.net/browse/HHH-18585