HHH-14584 Allow PhysicalNamingStrategy implementations to detect when a name is implicit or explicit #10366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
reviewed
Jun 17, 2025
Comment on lines
929
to
933
| Identifier logicalName = null; | ||
| if ( name != null ) { | ||
| logicalName = getDatabase().toIdentifier( name ); | ||
| logicalName.setExplicit( isExplicit ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| Identifier logicalName = null; | |
| if ( name != null ) { | |
| logicalName = getDatabase().toIdentifier( name ); | |
| logicalName.setExplicit( isExplicit ); | |
| } | |
| final Identifier logicalName; | |
| if ( name == null ) { | |
| logicalName = null | |
| } | |
| else { | |
| logicalName = getDatabase().toIdentifier( name ); | |
| logicalName.setExplicit( isExplicit ); | |
| } |
| if ( applyNamingStrategy ) { | ||
| final Database database = getDatabase(); | ||
| Identifier identifier = database.toIdentifier( columnName ); |
There was a problem hiding this comment.
Suggested change
| Identifier identifier = database.toIdentifier( columnName ); | |
| final Identifier identifier = database.toIdentifier( columnName ); |
| @@ -1773,7 +1773,10 @@ public MetadataBuildingContext getBuildingContext() { | |||
|
|
|||
| @Override | |||
| public Identifier handleExplicitName(String explicitName, MetadataBuildingContext buildingContext) { | |||
| return jdbcEnvironment( buildingContext ).getIdentifierHelper().toIdentifier( explicitName ); | |||
| Identifier identifier = jdbcEnvironment( buildingContext ).getIdentifierHelper() | |||
There was a problem hiding this comment.
Suggested change
| Identifier identifier = jdbcEnvironment( buildingContext ).getIdentifierHelper() | |
| final Identifier identifier = jdbcEnvironment( buildingContext ).getIdentifierHelper() |
| @@ -23,6 +23,7 @@ | |||
| public class Identifier implements Comparable<Identifier> { | |||
| private final String text; | |||
| private final boolean isQuoted; | |||
| private boolean isExplicit; | |||
There was a problem hiding this comment.
It would probably be better to keep Identifier is a completely immutable object, and overload Database.toIdentifier() to accept isExplicit is a parameter.
| @@ -352,10 +352,12 @@ private static QualifiedName sequenceName( | |||
| IdentifierHelper identifierHelper) { | |||
| if ( isNotEmpty( explicitSequenceName ) ) { | |||
| // we have an explicit name, use it | |||
| return explicitSequenceName.contains(".") | |||
| QualifiedNameParser.NameParts nameParts = explicitSequenceName.contains( "." ) | |||
There was a problem hiding this comment.
Suggested change
| QualifiedNameParser.NameParts nameParts = explicitSequenceName.contains( "." ) | |
| final QualifiedNameParser.NameParts nameParts = explicitSequenceName.contains( "." ) |
… a name is implicit or explicit
peter1123581321
force-pushed
the
HHH-14584
branch
from
f3a867d to
f2c18e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HHH-14584, an additional field was requested in
Identifierto indicate explicit namings of columns.This would allow more possibilies in a custom
PhysicalNamingStrategy.As
PhysicalNamingStrategyalso provides methods for sequences and tables, this PR also implements handling explicit namings of both of them.However, I did not provide it for schemas and catalogs.
Many thanks in advance for feedback, comments and change requests. :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-14584