Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config to force scheme for the server request. #354

Open
wants to merge 3 commits into
base: PHP-7.x
Choose a base branch
from

Conversation

lotharthesavior
Copy link

Hello,

I'm looking forward to hear others opinion in this subject. While trying to set up a Swoole server along, without any proxy, I faced the challenge of not being able to properly make sure that all the routes in the application had the same scheme (HTTPS). After some investigation I noticed that what was failing was the fact that Swoole (I'm using 4.6.6, but I tested since 4.5.*) is not adding to the request the 'scheme'.

I wonder if this is a problem on my local, but after many different combinations, php8.0-cli, php7.4-cli, laravel 8, bare metal, dockerized, I get the same always.

That said, I added this fix, that worked for all the tests that I did, and for all the helpers and routes generators through laravel.

IF this is something thet others are also experiencing, it might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant