Don't try to add <<__Override>> to private methods

hhvm · Sep 26, 2017 · 378125c · 378125c · fredemmott · Sep 26, 2017
1 parent af27365
commit 378125c
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/Linters/MustUseOverrideAttributeLinter.php b/src/Linters/MustUseOverrideAttributeLinter.php
@@ -21,6 +21,7 @@
   GenericTypeSpecifier,
   ListItem,
   MethodishDeclaration,
+  PrivateToken,
   SimpleTypeSpecifier
 };
 use namespace Facebook\TypeAssert;
@@ -124,6 +125,13 @@ private function canIgnoreMethod(
       return true;
     }
 
+    $private = $method->getModifiersx()->getDescendantsOfType(
+      PrivateToken::class,
+    ) |> C\first($$);
+    if ($private !== null) {
+      return true;
+    }
+
     if (!$class->getKeyword() instanceof ClassToken) {
       return true;
     }