Make odate work with OCaml >4.06 and OPAM >2.0 #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now oDate cannot be built and installed with OCaml >4.06 and OPAM 2.x. This is unfortunate because there's no better library for parsing datetime strings!
calendar is fine for parsing dates, but its implementation doesn't work right with formats that include both date and time (ocaml-community/calendar#35).
Thus I really would love to see a new release of oDate. These patches update the code to use
Stdlib
rather than old-stylePervasives
. Since there's only one dependent package (coclobas), I believe it will not cause big problems.@smondet Please confirm or deny whether you are fine with this change.
The OPAM file now works with 2.0 and should be ready for a PR. I successfully did
opam pin add .
with OCaml 4.10 and opam 2.0.7: