Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure uncertainties does not depend on numpy #2001

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

tgbugs
Copy link
Contributor

@tgbugs tgbugs commented May 30, 2024

Fix import ordering to ensure that uncertainties can be used without numpy, before this the check assumed that numpy was always installed.

@andrewgsavage
Copy link
Collaborator

you'll need to run the linter or add a line

the failing test_issue1611 might need to be have requires_uncertainties

Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #2001 will not alter performance

Comparing tgbugs:fix-unc-np-coupling (73a4174) with master (ad02b87)

Summary

✅ 437 untouched benchmarks

fix import ordering to ensure that uncertainties can be used without
numpy, before this the check assumed that numpy was always installed

update test_issue1611 to use requires_numpy since uncertainties and
numpy are now decoupled
@andrewgsavage andrewgsavage merged commit 6483353 into hgrecco:master Jul 8, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants