Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depreciate ureg.__getitem__ #1997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewgsavage
Copy link
Collaborator

I hadn't noticed a depreciate warning for ureg.getitem when using pint. This PR changes the depreciation from a logger message to DeprecationWarning.

metioned in #1303

Copy link

codspeed-hq bot commented May 26, 2024

CodSpeed Performance Report

Merging #1997 will improve performances by 52.29%

Comparing andrewgsavage:getitem (09acae1) with master (9972e60)

Summary

⚡ 15 improvements
✅ 422 untouched benchmarks

Benchmarks breakdown

Benchmark master andrewgsavage:getitem Change
test_getitem[False-angstrom] 393.3 µs 264.7 µs +48.57%
test_getitem[False-kilometer] 404.1 µs 274.9 µs +47.01%
test_getitem[False-meter] 386.8 µs 259.5 µs +49.06%
test_getitem[False-millisecond] 406.7 µs 275.7 µs +47.5%
test_getitem[False-minute] 389.3 µs 261.8 µs +48.69%
test_getitem[False-ms] 617 µs 497.6 µs +24%
test_getitem[False-second] 397.2 µs 267.1 µs +48.71%
test_getitem[True-angstrom] 395.4 µs 265.9 µs +48.7%
test_getitem[True-kilometer] 404 µs 273 µs +47.99%
test_getitem[True-meter] 394 µs 258.7 µs +52.29%
test_getitem[True-millisecond] 407 µs 276.8 µs +47.03%
test_getitem[True-minute] 396.2 µs 264.3 µs +49.94%
test_getitem[True-ms] 623 µs 497.5 µs +25.24%
test_getitem[True-second] 392.1 µs 259.5 µs +51.11%
test_finding_meter_getitem 382.3 µs 256.5 µs +49.06%

@hgrecco
Copy link
Owner

hgrecco commented Jul 28, 2024

I will leave this open until just before the next minor release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants