Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix converting to offset units of higher dimension e.g. gauge pressure #1952

Merged
merged 4 commits into from
May 12, 2024
Merged

Fix converting to offset units of higher dimension e.g. gauge pressure #1952

merged 4 commits into from
May 12, 2024

Conversation

dalito
Copy link
Contributor

@dalito dalito commented Mar 8, 2024 •
edited
Loading

  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

Closes #1949

@dalito dalito force-pushed the issue1949 branch 2 times, most recently from 97b78c4 to 346145a Compare March 8, 2024 22:56
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1952 will not alter performance

Comparing dalito:issue1949 (0c1056a) with master (2b4a8b7)

Summary

✅ 437 untouched benchmarks

@dalito dalito mentioned this pull request Mar 8, 2024
Closed
@andrewgsavage andrewgsavage merged commit cbdd79e into hgrecco:master May 12, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Units with offsets raise DimensionalityError in 0.23
2 participants
@dalito @andrewgsavage