Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkg_resources in test_load #1870

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

musicinmybrain
Copy link
Contributor

@musicinmybrain musicinmybrain commented Oct 30, 2023

Replace pkg_resources.resource_filename with
importlib.resources.files. This removes an implicit dependency on setuptools (to which pkg_resources belongs); furthermore, the entire pkg_resources API is deprecated.

Regarding the switch from __file__ to __package__, see: python/importlib_resources#60

  • Closes # (insert issue number) N/A, no issue filed
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests N/A, only test code is modified
  • Documented in docs/ as appropriate N/A, no user-visible change
  • Added an entry to the CHANGES file Do we really need a changelog entry for this?

Replace pkg_resources.resource_filename with importlib.resources.files.
This removes an implicit dependency on setuptools (to which
pkg_resources belongs); furthermore, the entire pkg_resources API is
deprecated.

Regarding the switch from __file__ to __package__, see:
python/importlib_resources#60
Copy link

codspeed-hq bot commented Nov 1, 2023

CodSpeed Performance Report

Merging #1870 will not alter performance

Comparing musicinmybrain:setuptools-test (3f8a048) with master (f9e139e)

Summary

✅ 439 untouched benchmarks

@hgrecco hgrecco merged commit 37127e1 into hgrecco:master Dec 3, 2023
34 checks passed
@hgrecco
Copy link
Owner

hgrecco commented Dec 3, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants