Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError when combining auto_reduce_dimensions=True and non_int_type=Decimal #1853

Merged
merged 9 commits into from
May 12, 2024

Conversation

jonemo
Copy link
Contributor

@jonemo jonemo commented Sep 22, 2023

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2023

CodSpeed Performance Report

Merging #1853 will not alter performance

Comparing jonemo:issue-1845 (a93b80d) with master (7262388)

Summary

✅ 437 untouched benchmarks

@hgrecco
Copy link
Owner

hgrecco commented Dec 3, 2023

I was about to merge but your PR modified the whole changelog format.

@jonemo
Copy link
Contributor Author

jonemo commented Dec 3, 2023

I was about to merge but your PR modified the whole changelog format.

Sorry, looks like an over-eager auto-formatter paid too much attention while I paid too little. Fixed it.

@andrewgsavage andrewgsavage merged commit c0501ff into hgrecco:master May 12, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when combining auto_reduce_dimensions=True and non_int_type=Decimal
3 participants