Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pint-xarray's CI to the downstream status page #1847

Merged
merged 3 commits into from
Sep 17, 2023

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Sep 16, 2023

  • Executed pre-commit run --all-files with no errors

@keewis keewis force-pushed the downstream-status-pint-xarray branch from 2621584 to 09a2142 Compare September 16, 2023 11:35
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 16, 2023

CodSpeed Performance Report

Merging #1847 will improve performances by 22.77%

Comparing keewis:downstream-status-pint-xarray (09a2142) with master (07646d0)

Summary

⚡ 1 improvements
✅ 420 untouched benchmarks

Benchmarks breakdown

Benchmark master keewis:downstream-status-pint-xarray Change
test_op1[neg-float_kilometer] 163.5 µs 133.2 µs +22.77%

@keewis
Copy link
Contributor Author

keewis commented Sep 16, 2023

I wondered if we could improve the page by formatting the list as a table and tried it, the result is the last commit here. This does make the page look a bit nicer, although mdformat expands the source to be equally sized everywhere, including the huge links, which makes editing a bit hard (does anyone know if we can avoid that somehow?).

@hgrecco hgrecco merged commit cf8cced into hgrecco:master Sep 17, 2023
33 checks passed
@hgrecco
Copy link
Owner

hgrecco commented Sep 17, 2023

@keewis I agree that the rendered table looks much nicer! I do not know if there is a way to improve the non rendered format. Is there a way to use indirection?

@keewis keewis deleted the downstream-status-pint-xarray branch September 17, 2023 19:05
@keewis
Copy link
Contributor Author

keewis commented Sep 17, 2023

there is in github flavored markdown, not sure about others. I guess it depends on what we want to do with that page?

@hgrecco
Copy link
Owner

hgrecco commented Sep 17, 2023

IMO is only for github. We use it to check if everything is ok before releasing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants