In _parse_units make as_delta and case_sensitive mandatory and pure b…

…oolean. Also make external uses of _parse_units to parse_units
hgrecco · Jul 15, 2023 · 7979d07 · 7979d07
1 parent f23e451
commit 7979d07
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/pint/facets/plain/registry.py b/pint/facets/plain/registry.py
@@ -1167,8 +1167,8 @@ def parse_units(
     def _parse_units(
         self,
         input_string: str,
-        as_delta: bool = True,
-        case_sensitive: Optional[bool] = None,
+        as_delta: bool,
+        case_sensitive: bool,
     ) -> UnitsContainer:
         """Parse a units expression and returns a UnitContainer with
         the canonical names.

diff --git a/pint/util.py b/pint/util.py
@@ -1039,8 +1039,7 @@ def to_units_container(
         return unit_like._units
     elif str in mro:
         if registry:
-            # TODO: Why not parse.units here?
-            return registry._parse_units(unit_like)
+            return registry.parse_units(unit_like)
         else:
             return ParserHelper.from_string(unit_like)
     elif dict in mro: