Add support for SHA256 and SHA512

[y3nr1ng]

Using a selector to choose between SHA1, SHA256 and SHA512. Hash algorithm is still default to SHA1.

[hgfischer]

Thanks @Liuyenting! But to merge it, could you please add some test new cases?

[y3nr1ng]

Sure, but what's the criteria of the test?
Do I have to extend the functions in the original test cases as well?

[hgfischer]

Let's just keep the 100% test coverage. You can check with make cover.

[hgfischer]

Hi @Liuyenting

Do you still have the intent to fix the test coverage?

[y3nr1ng]

Hi there... I'm facing my midterm right now, it's will be over in two weeks. Is it okay for me to patch this up at that time?

[hgfischer]

Sure. :)

On 14 April 2016 at 15:47, Liu Yen-Ting [email protected] wrote:

Hi there... I'm facing my midterm, it's will be over in two weeks. Is it
okay for me to patch this up at that time?

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#5 (comment)

[hgfischer]

The proposal is still up. ;)

[y3nr1ng]

Uh oh... I've completely forgotten about this, gonna look into this immediately! Lucky me, summer vacation in progress.