feat: Add an API for defining cronjobs #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defines an easier API for creating cronjobs that run within the bot. It also adds /cron <start/stop> commands to control individual or all crons fix: please the formatter gods? fix: isort things
itskarudo
force-pushed
the
cronjob-things
branch
from
2cdb918 to
07aabac
Compare
hfz1337
reviewed
Nov 29, 2024
hfz1337
reviewed
Nov 29, 2024
Co-authored-by: hfz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines an easier API for creating cronjobs that run within the bot. It also adds /cron <start/stop> commands to control individual or all crons.
It can be used to eventually refactor crons such as
create_upcoming_eventsout of the main bot class.This interface still feels a bit wonky on some corners, any feedback would be appreciated.