Fixing core to work with win32 #1257 #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimsag
reviewed
Aug 25, 2024
| @@ -348,6 +348,10 @@ pub fn start(core: *Mod) !void { | |||
| } | |||
| } | |||
|
|
|||
| fn dispatch(stack_space: []u8) void { | |||
There was a problem hiding this comment.
What's the reason this intermediate function call is needed? Or, what error do you get without this?
There was a problem hiding this comment.
This is the error I get is
src\module\module.zig:325:27: error: unable to resolve inferred error set
try m.dispatch(stack_space, .{
without digging much deeper my assumption was might be occurring because it was being called from a "system" which is analyzed when creating the .Mod.
I saw platform_update_callback did not have this issue. That is why I created a function dispatch that would catch the error and not propagate the error thus breaking the loop when the compiler is determining the error set.
slimsag
reviewed
Aug 25, 2024
| @@ -130,6 +130,7 @@ pub fn init( | |||
| self.border = options.border; | |||
| self.headless = options.headless; | |||
| self.refresh_rate = 60; // TODO (win32) get monitor refresh rate | |||
| self.vsync_mode = .triple; | |||
slimsag
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use core.state()
Moved dispatch call from a system to its own function.
Set a default vsync mode in win32. There are some stability issues when free running.