docs: Add a social media share icon #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
zh
|
Theme name validation passed. |
yoshinorin
requested changes
Apr 1, 2024
source/index.md
Outdated
| @@ -2,6 +2,7 @@ | |||
| layout: index | |||
| description: Hexo is a fast, simple & powerful blog framework powered by Node.js. | |||
| subtitle: A fast, simple & powerful blog framework | |||
| og_image: /themes/screenshots/landscape.png | |||
There was a problem hiding this comment.
It would be better to set the official logo as the og:image for all pages. There's no need to change it page by page. So, we no need to specify og_image in each posts or pages.
There was a problem hiding this comment.
fixed with 8956360
themes/navy/layout/partial/head.njk
Outdated
| @@ -39,6 +39,8 @@ | |||
| <!-- Open Graph --> | |||
| {{ open_graph({ | |||
| fb_admins: config.fb_admins, | |||
| image: url_for(page.og_image or 'icon/og-image-wide.png'), | |||
There was a problem hiding this comment.
Also, no need or here. We just add image: url_for('icon/og-image-wide.png') :)
There was a problem hiding this comment.
fixed with 8956360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Thank you for reviewing the Japanese translation.
I tried to post about its publication on social media, but:
X:
Facebook:
NOTE: In the preview, no image is displayed, but upon actual sharing, the Netlify logo image at the bottom of the page appears, which may not be suitable
Since the image was not displayed, the post ended up looking very plain 😅
Therefore, I propose setting a specific page on the Hexo Official Website as the Open Graph Image and Twitter Summary Card image.
After implementing this pull request, posts on social media will display as follows:
NOTE: These images were generated with OGP Image Simulator and may be slightly different from the actual image.
X:
Facebook:
Previously, only the index page displayed the thumbnail of the
landscapethemeAlthough that behavior was unintentional, to prevent it from being replaced by this pull request, we should explicitly designate the landscape image on the index page as the image for social media.
Thank you for your attention.
Check List
Please read and check followings before submitting a PR.
enEnglishruRussianzh-cnsimplified Chinesezh-twtraditional ChinesejaJapanese