WIP: refactor: refactor types #5483
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b test/perf https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
SukkaW
reviewed
Apr 29, 2024
Pull Request Test Coverage Report for Build 9817883538Details
💛 - Coveralls |
SukkaW
requested changes
Apr 30, 2024
| @@ -407,6 +431,11 @@ class Hexo extends EventEmitter { | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| * Load configuration and plugins. | |||
| * @returns {Promise} | |||
There was a problem hiding this comment.
Let's use TypeScript definition only, the JSDoc types can be omitted.
SukkaW
reviewed
Apr 30, 2024
| @@ -10,7 +11,7 @@ export = (ctx: Hexo) => { | |||
| renderable: {type: Boolean, default: true} | |||
| }); | |||
|
|
|||
| Asset.virtual('source').get(function() { | |||
| Asset.virtual('source').get(function(this: AssetSchema) { | |||
There was a problem hiding this comment.
Let's improve the warehouse's virtual type to infer this here.
2 tasks
|
pending: warehouse new release |
Would you please submit a release PR to warehouse repository? I'll release a new one. Thanks :) |
IMHO, it's better to fix hexojs/warehouse#252 for better type support before release a new version. But I'm not sure how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.